[LH 1.7 BETA] MasterArcher (Part II) #FIXED

from Elemental Forums

+ Added the ability to have these conditional modifiers based on either the attacker or the targets unit stats.  (ie: Master Archer is based on the unit having UnitStat_IsBow value that all bows give, Death Blow is based on the target having less than 20 hit points). (for modders)

 

As has been reported here, I don't think MasterArcher (Conditional modifiers based on the attacker UnitStat) is behaving properly. The +25 critical bonus is applied in all instances (Bow or not).

 

Temporary fix (Using Ability/BattleAutoCast/Spell/UnitStat)

[Link removed]

 

I tried a Reverse MasterArcher (Conditional modifiers based on the target UnitStat) and it's behaving as it should. At this point wondering if the <BoolVal1>1</BoolVal1> is doing what it should be doing and/or if the <GameModifier> is missing a specific <vsABC> applicable to an attacker UnitStat comparison. Otherwise, is the comparison vsLower or vsHigher? (However, simply adding vsLower/vsHigher switches the comparison to Target UnitStat instead of Attacker UnitStat).

 

 

 

_________________________

LH Mods by Primal

XtraDeconstruct

XtraDeconstruct Canons

22,571 views 18 replies
Reply #1 from Elemental Forums Top

I just started playing again.  Is this only found on items?  I was expecting it to be a trait or something.

Reply #2 from Stardock Forums Top

This will be fixed in 1.7.

Elemental: Reforged
Reply #4 from Elemental Forums Top

Yeah really want this fixed.

Maybe change the thread from [1.6] to [1.7 beta]  so Derek will find it?

 

Reply #5 from Elemental Forums Top

You are right, its broken.

Unfortunately conditional abilities are calculated during the attack (since they consider the targets stats as part of the comparison). Even in this case where the targets stat isnt considered (since it's only if the attacker has a bow or not) it still isn't calculated until the attack happens.  Its because I'm using the conditional modifiers system for something it was never intended to do.

Either way I did fix the Master Archer ability so it will work correctly in the 1.7 public patch. Thanks for the feedback!

+1 Loading…
Reply #6 from Elemental Forums Top

Oh man... I was banging my head against the wall trying to get a spell to work using these new conditional modifiers... No matter what I would try, they would just not do anything. Glad to know I'm not crazy!

Reply #7 from Elemental Forums Top

Nobody ever answered my earlier question--where do I find this trait?  It's obviously not part of a trait tree for a class so is it only on items?

Reply #8 from Elemental Forums Top

Quoting Fezziwig, reply 7

Nobody ever answered my earlier question--where do I find this trait?  It's obviously not part of a trait tree for a class so is it only on items?

There is a single hero who has this trait.  It cannot be learned by anyone else.

Reply #9 from Elemental Forums Top

Quoting mqpiffle, reply 8


Quoting Fezziwig, reply 7
Nobody ever answered my earlier question--where do I find this trait?  It's obviously not part of a trait tree for a class so is it only on items?

There is a single hero who has this trait.  It cannot be learned by anyone else.

Thanks!

Reply #10 from Elemental Forums Top

If only someone would mod the assassin path to include master archer...

Reply #12 from Elemental Forums Top

Anyone know if this is working properly? 

 

Reply #14 from Elemental Forums Top

Cool thanks.

Reply #15 from Elemental Forums Top

I don't get it, is this supposed to show on the units attributes, like in the Unit Details window?

Because it looks like it does nothing... if you give a champion the Master Archer trait, then equip a bow, it doesn't change their critical chance according to the Unit Details window.  

So does it work, and it just doesn't show the change in stat?  I'm guessing based on what Kael said ("it still isn't calculated until the attack happens") maybe it just kicks in when you go to attack someone.

Does that sound right?

Reply #17 from Elemental Forums Top

Great thanks for posting the changes to the syntax across the versions.  Shame it doesn't show up under the Unit Details.. I want to use this approach for some stuff, would be nice to know it's working without having to go and actually test everything each time to see the effect.

But that's cool if it works i'll just cope paste and hope I don't stuff it up.

Reply #18 from Elemental Forums Top

Ha, I just asked Primal the same question as abob101.

Modder life y'all.