This is amazing!

Correct!

So I was trying to update some of my mods to use this. Except looking at the CoreSpells.xml file in the Replacement folder it only contains summons. Shouldn't this replace the existing CoreSpells.xml and contain all spells? 

No, for the purpose of the mod there would be no point. And installation folder core files are not overwritten by clashing filenames.

So Heavenfall, I don't remember installing this (been trying to keep my install relatively clean for my own modding, although this mod is a good idea), but it looks like part of it has crept into the code (seeing Is Immortal, etc. in the code that is outputted from custom Sovereign creation).  Am i imagining things?

It crept into DLC xml files, thanks to Derek. By any chance was your custom sovereign undead?

Why yes, it WAS a few Undead custom Sovs that saw this code!

Sounds like we are part way there.  So now we just need to get it embedded into the 'rest' of the code!

I haven't created a 'non-undead' Sov since I downloaded the DLCs, so I have no idea if said tags would show up with regular Sovs if you have DLC04.

Custom sovereigns are made from "generic" sovereign xml. In the unmodded game, only DLC 04 undead sovereigns have those tags. However, if you have this library installed it will appear for other factions as well.

Hi HF,

Just been trawling through you modified CoreMonsterUnitTypes.xml making some edits.... and i've noticed that you have flagged thse guys as counting as "Demons"....

- Crow Demon

- Cyndrum Demon

But not the Burning Wraith, Mirror Elementals or Grave Elementals.

I'm far from an expert on the lore, but my understanding is that these were all pretty much created the same way.. by corrupting Elementals... so i'm wondering if they should either all count as "Demon" or not, despite the names of them.

Just comes down to whether or not the corrupting process essentially turns the elementals into a demonic creature or not.

What do you think?

For the base stuff I wanted to avoid making such decisions as much as possible. If it didn't explicitly say it was a demon I didn't add it. But if you have a list of suggested changes I'd be very interested in seeing it.

I don't so much have a list, but I have quite a few spells and other things in Demons and Wizards that affect "Demons" and/or "Celestial" so i'm just checking out what you have flagged as these.

I've been thinking about these bound elementals and I think (in D&W) i'm going to make them all count as Demons, to be consistent.  The Backstory for Cyndrums mention them as "demons" so i'm going to go ahead and assuming that whatever Ceresa did to these elementals... they are all now are corrupted to the point of possessing demon qualities.

So they'll all suffer extra damage from Holy stuff and be immune to some things.

That's the only tweak to the BG stats i've done, i've got a few other minor things but they're more balances changes

Hi HF,

I'm using this library with my new mod that extra races, and i'm thinking these 2 unitstats might not work correctly for user created factions, if the faction uses a race for an allegiance it was not originally intended.  What I mean is....

The unitstats UnitStat_BG_IsEmpire and UnitStat_BG_IsKingdom are attached the the UnitType.

The UnitType(s) are attached to the RaceType.

But we can't restrict a RaceType so that it is only available to Kingdom or Empire.  Even default races like Altarian can be Kingdom or Empire when used in a users created Faction (using the front end Faction Creator).

So the problem is if the user creates a new "Empire" Altarian faction... the units will have UnitStat_BG_IsKingdom attached, which is "wrong".

Does that sound correct ?

Yeah, they'd have to create new unittypes then. I should clarify that the unitstats are not inherent from the faction but from the race. Altarian race is considered kingdom no matter what your faction is.

OK, so I'm trying to use a BG Stat (one I added for my faction) to check against before a spell adds an ability to a unit.

Essentially UnitStat_BG_IsRevenant is the stat I've made.

I have an Ability, RevenantWays, which unlocks some Revenant Abilities for Champions not of the Revanant race.

Essentially my Revenant Champs/Sovs already have access to different versions of these abilities (depending on race subtype), so they don't need access to the 'Generic Perks' (This is a Fire vs Ice vs Pierce thing).  This would just clutter up the tree.  This 'RevenantWays' ability is to unlock some generic perks for 'normals' whom are essentially still living.

I'm trying to contemplate the gamemodifier tag, but not sure about the syntax/if this would even work.

        <GameModifier>
            <ModType>Unit</ModType>
            <Attribute>UnlockUnitAbility</Attribute>
            <StrVal>RevenantPerks</StrVal>
            <StrVal2>UnitStat_BG_IsRevenant</StrVal2>
                <Value>This Is Where I Get Lost, already mentioned RevenantPerks above</Value>
                <vsLower>1</vsLower>
            </GameModifier>

My thought was that (since I defaulted UnitStat_BG_IsRevenant to 0.0 in the stat definition for it in PlayerAbilityTypes) that pretty much everyone besides Revenants would have a value of 0, which is lower than 1.  Revenants are assigned a value of 1 via the 'FactionRevenant' ability I have for them.

Any thoughts on how one might accomplish this with a BG stat (Add an ability via a spell to a unit that doesn't already have a similar but slightly different ability/BG Stat value is 0 & disallow if 1 or higher)?

What are you trying to do? If I'm reading you right, you have a spell that you want to use to check a stat, and if that stat exists apply a perk. I do not think this is possible with current XML.

I'm using a spell to create a perk for a Champion (spell shows up fine), but I don't want to create/add the perk if that unit has a value of of over 0 in a specific stat.  I.E.. if UnitStat_BG_IsRevenant equals 1 (or higher), then don't apply the GameModifier/Unlock the noted ability.  Essentially, if you are already the Race in guestion, you have other stats that address said ability, which work slightly differently.  I just want to make sure that the ability doesn't get added to the Revenant Champions/Sovs using this spell.  This would 'stack' some abilities, and cause a bunch of disorder on the General Trait tree to boot as abilities from both parent abilities would then populate the tree, which isn't the plan.

The other option is to add the ability to every other faction in the game, which gets problematic with custom factions and such.  No sense changing a bunch of files if I can just accomplish this with one or two Gamemodifiers...

It's been a while since I modded FE:LH, but as far as I remember there's no way to do that based on a unitstat.

What I would try is have this in your trait that gets applied through the spell:

      <Prereq>
        <Type>RestrictedAbilityBonusOption</Type>
        <Attribute>youroriginaltrait</Attribute>
        <Target>Unit</Target>
      </Prereq>

If you are lucky this may prevent the trait from being applied.

Tjashen, I think there's a different way to approach your spell. Instead of casting it on a champion, why not have the champion cast it on himself? This would enable you to make all kinds of restrictions about WHEN he can cast the spell. The spell would simply not show up unless certain conditions were met. This is how I did my Eternal Ressurection spell for champions serving my undead faction:

  <SpellDef InternalName="TurnUndead">
    <DisplayName>Eternal Resurrection</DisplayName>
    <Description>This spell begins the process of turning the caster into an undead soldier by feeding dark magic into the Champion's soul.

Champion will from now on gain experience at half normal rate, and receives no benefit from any bonuses that increases experience gain. Champion suffers -5 Initiative and is capped at 3 Strategic Health regeneration.

All Injuries are removed. Champion cannot suffer any new Injuries.

Champion drains 1 Death Shard power. Champion counts as Immortal, Undead and as if it belonged to the Race: Undead. Champion also maintains its old Race.</Description>
    <DeathShards>1</DeathShards>
    <AlwaysPromptForCaster>1</AlwaysPromptForCaster>
    <Image>Ability_GreaterCurse_Icon.png</Image>
    <IconFG>Ability_GreaterCurse_Icon.png</IconFG>
    <IconBG>Ability_GreaterCurse_Icon.png</IconBG>
    <IconColor>216,45,17</IconColor>
    <SpellType>Strategic</SpellType>
    <AutoUnlock>1</AutoUnlock>
    <SpellClass>Defensive</SpellClass>
    <SpellSubClass>Buff</SpellSubClass>
    <SpellTargetType>Self</SpellTargetType>
    <Cooldown>5000</Cooldown>
    <SpellResourceCost>
      <Resource>Mana</Resource>
      <Amount>100</Amount>
    </SpellResourceCost>
    <Prereq>
      <Type>UnitStat</Type>
      <Attribute>UnitStat_BG_HasInjuries</Attribute>
      <Value>1</Value>
    </Prereq>
    <Prereq>
      <Type>AbilityBonusOption</Type>
      <Attribute>DominionOfTheDead4</Attribute>
      <Target>Player</Target>
    </Prereq>
    <GameModifier>
      <ModType>Unit</ModType>
      <Attribute>HealInjuries</Attribute>
    </GameModifier>
    <GameModifier>
      <ModType>Unit</ModType>
      <Attribute>SetUnitStat</Attribute>
      <StrVal>UnitStat_ExpBonus</StrVal>
      <Value>-50</Value>
    </GameModifier>
    <GameModifier>
      <ModType>Unit</ModType>
      <Attribute>SetUnitStat</Attribute>
      <StrVal>UnitStat_BG_IsImmortal</StrVal>
      <Value>1</Value>
    </GameModifier>
    <GameModifier>
      <ModType>Unit</ModType>
      <Attribute>SetUnitStat</Attribute>
      <StrVal>UnitStat_BG_IsUndead</StrVal>
      <Value>1</Value>
    </GameModifier>
    <GameModifier>
      <ModType>Unit</ModType>
      <Attribute>SetUnitStat</Attribute>
      <StrVal>UnitStat_BG_IsRace_Undead</StrVal>
      <Value>1</Value>
    </GameModifier>
    <GameModifier>
      <ModType>Unit</ModType>
      <Attribute>UnlockUnitAbility</Attribute>
      <StrVal>TurnedUndead</StrVal>
    </GameModifier>
    <AIData AIPersonality="AI_General">
      <AIPriority>0</AIPriority>
    </AIData>
    <HitSoundFX>Spell_Enchant_02</HitSoundFX>
    <SpellDefEffect>
      <EffectName>S_Sacrifice_Particle</EffectName>
      <LocalPosition>0,50,0</LocalPosition>
      <EffectScale>1.5</EffectScale>
      <EffectDelay>0</EffectDelay>
      <SnapToTerrain>1</SnapToTerrain>
    </SpellDefEffect>
  </SpellDef>

Essentially that's what I saw in the Demilich abilitiy for Necromancy Revamped.  Sov cast spell on himself, Sov only spell.  In this case, some Champions will need it (depending on how many Undead/Revenant Champions I create).

I've been hammering away at this for a while again, so I'll look at your approach more closely when I get a chance later today.

Heya HF,

I want to create a faction trait that provides a bonus to all faction units vs a particular unitstat (IsDemon etc).

I can add it to a blood trait easy enough (like the Revenge of the Forest for Elves where they get a bonus vs ExpandedTraits_FLAG_DefendingCityWithLumberMill), but i'm really trying to do it via a faction trait.

Any ideas?

Cheers.

I don't believe you can add a trait to all units owned by a faction. There may be a way to do it for all TRAINED units though. I can look it up if you're still interested, but it'll take some digging because it was only used in early FE patches.

Yeah it's a bit of a bugger, i'm working on some faction traits but there's a lot of limitations on what can be done. 

The only idea I have currently is to have an autocast applied to all blood traits... that boosts Attack vs Demons (or whatever) based on a new UnitStat_X.  Then have the faction trait increase the UnitStat_X for all the factions units using A_UnitStat_X.

So that would work for all units that have the blood but requires adding something to all blood traits.  So all blood traits would autocast the spell but only those with A_UnitStat_X would actually get the bonus.  Kinda messy.

I'd much prefer it applied to all units if possible.... and/or if there is an easier way to do it would be preferable I just can't think of anything.

No drama, just wondering if I was missing something obvious.... doesn't seem like it though.

Thanks.

I thought you could set a trait to unlock when the unit is created to have a second trait as its prereq.  So for instance Dummy_trait1 auto-unlocks when you have blood_altair trait.

Yep you can do that with a unit design trait... but what i'm trying to do is have a faction (Player) ability trait that automatically gives all units the bonus.  So for example you can use A_UnitStat_Accuracy to give all units for a faction an accuracy bonus.

But i'd like to be able to do something like:

<GameModifier>
  <ModType>Player</ModType>
  <Attribute>AbilityBonus</Attribute>
  <StrVal>A_UnitStat_Accuracy</StrVal>
  <StrVal2>UnitStat_BG_Demon</StrVal2>
  <vsHigher>1</vsHigher>
  <Value>10</Value>
  <Provides>All faction units are +10 Accuray vs Demons</Provides>
</GameModifier>

But that won't work.  Well actually I haven't tried it but i'm 99% sure it won't.

Actually you can just make a new blood trait with that added in using the initial blood trait as a base.  Unless you are trying to avoid that then I am not sure what you can do.