[.80][UI] Fixed several stamps (DONE!!!)

from Elemental Forums

I was looking into why some of the rivers were acting strangely and I noticed there are a few errors in the stamp data...I'll update this post from time to time

fixed the scrapyard data...https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Scrapyard_Blank_01.zip

The scrapyard had this issue

if you see the waterfall in the water... Simple fix

Tile Number (31,9) is a submerged tile... Removed from <MapRiverData> section
Tile Number (30,9) was labeled as river sub-terrain land, changed to <TerrainType>Cliff<\TerrainType>

Thus, we get this result instead

There are many issues in the file S_Northern_Wastes_Blank_01.xml

There are a lot of supposed river tiles that are not actually defined as river tiles... and rivers that end not on a cliff edge causing land endings.

22,562 views 29 replies
Reply #1 from Elemental Forums Top

Excellent!  That looks like the stamp I had reported earlier on .50 had a waterfall out in the ocean.

Reply #2 from Elemental Forums Top

Parrotmath, when are you going to work for SD full-time? You rock!

Object Desktop - Get all of our enhancement utilities in one suite
Reply #3 from Elemental Forums Top


Is SD going to take this into the base game or am I going to have to download it as a mod?

 

Reply #4 from Elemental Forums Top


Awesome! Congratulations Parrotmath k5 :thumbsup:

Reply #5 from Elemental Forums Top

I checked in your fix, thanks Parrottmath!

And I second Lord Reliant's question, you wouldn't happen to live in Michigan do you?

Reply #6 from Elemental Forums Top

Here's another bad stamp, a waterfall sticking up in the middle of nowhere:

Here's the saved game.  The water fall is in the upper left part of the explored region.

Reply #7 from Elemental Forums Top

Woah. Parrotmath, if you get a job at SD, promise me I'll get a tour! I hear Michigan is lovely in the spring. :)

Reply #8 from Elemental Forums Top

There are many issues in the file S_Northern_Wastes_Blank_01.xml

Well I have a version that I think doesn't cause any problems. I fixed up S_Northern_Wastes_Blank_01.xml and W_Northern_Wastes_01.xml so there are no longer river tiles that are not river tiles in the center of the northern wastes. Most of the cliff changes were to prevent the rivers from ending with a land waterfall ending. I hope I kept the inspiration behind these tiles.

Here are a list of the changes I did for these two files

S_Northern_Wastes_Blank_01.xml (Lots of Errors in the River Data)

Added Tile (3,10) to be submerged
Changed Tile (3,9) to cliff
Changed Tile (3,11) to cliff
Changed Tile (4,9) to cliff
Changed Tile (4,10) to cliff
Changed tile (4,11) to cliff
Changed Tile (5,10) to river...matching <MapRiverData>
Changed TIle (6,10) to river...matching <MapRiverData>
Changed Tile (7,10) to river...matching <MapRiverData>
Changed Tile (7,11) to river...matching <MapRiverData>
Changed Tile (7,12) to river...matching <MapRiverData>
Changed Tile (8,12) to river...matching <MapRiverData>
Changed Tile (8,13) to river...matching <MapRiverData>
Changed Tile (14,9) to ArcticTerrain from river...matching <MapRiverData> info
Changed Tile (15,9) to ArcticTerrain from river...matching <MapRiverData> info
Changed Tile (16,8) to ArcticTerrain from river...matching <MapRiverData> info
Changed Tile (17,3) to ArcticTerrain from river...matching <MapRiverData> info
Changed Tile (25,6) to ArcticTerrain from river...matching <MapRiverData> info
Changed Tile (26,2) to Cliff
Changed Tile (26,3) to Cliff
Changed Tile (26,4) to River...matching <MapRiverData>
Changed Tile (26,5) to River...matching <MapRiverData>
Changed Tile (27,4) to River...matching <MapRiverData>
Changed Tile (27,3) to Cliff...matching <MapRiverData>
Added Tile (27,2) Sumberged
Changed Tile (28,1) to Cliff
Changed Tile (28,2) to Cliff
Changed Tile (28,3) to Cliff
Changed Tile (28,11) to be Fertile_Land...matching <MapRiverData> info
Changed Tile (28,12) to be Fertile_Land...Matching <MapRiverData> info

W_Norther_Wastes_01.xml

Changed Tile (7,4) to river...matching <MapRiverData>
Changed Tile (7,6) to forest from river...matching <MapRiverData>
Changed Tile (8,6) to ArcticTerrain from river...matching <MapRiverData>
Changed Tile (9,6) to ArcticTerrain from river...matching <MapRiverData>
Changed Tile (10,2) to ArcticTerrain from river...matching <MapRiverData>
Changed Tile (10,3) to ArcticTerrain from river...matching <MapRiverData>
Changed Tile (10,5) to ArcticTerrain from river...matching <MapRiverData>
Changed Tile (11,0) to ArcticTerrain from river...matching <MapRiverData>
Changed tile (2,9) to river...matching <MapRiverData>
Changed tile (2,10) to river...matching <MapRiverData>
Changed tile (1,7) to river...matching <MapRiverData>
Changed Tile (1,8) to river...matching <MapRiverData>
Changed Tile (1,9) to river...matching <MapRiverData>

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/Northern_Wastes.zip

Reply #10 from Elemental Forums Top

I'm assuming we extract these and put them in the my games/legendaryheroes/stamps folder? 

 

or the

 

C:\Users\Owner\Documents\My Games\LegendaryHeroes\Mods\Data\English folder?

 

Top one is the only reference to 'stamps' in the my docs folder, so that's my assumption.

Reply #11 from Elemental Forums Top

Honestly I'm not sure if they will work from the stamps folder. I've been doing a direct overwrite at the moment. I'll check and let you know.

Edit: I've checked and it appears that for the stamps to appear appropriately one needs to overwrite them in the game folder at the moment. If you plan on doing that please back up your files that you are going to overwrite.

Reply #12 from Elemental Forums Top

The phantom river problem seems to be a problem in how the game puts the stamps together. If a stamp is placed next to a stamp with a river and part of that river is overwritten with some other data, the entire river disappears visually. Although the river still exists in parts where the stamp hadn't overwritten the existing river. I've noticed this several times and this is my conclusion on some of the phantom river tiles.

Reply #13 from Elemental Forums Top

Actually I've been viewing some of the stamps (wow, what a pain in the ass that is, can't even load stamps as a default in the Cartographer) and the stamps are a built that way (with the phantom tiles.)  Unfortunately I'm not able to edit the stamps for some reason.

What did you have to do to get the stamps to load into the Cartographer properly so you could edit them?

Reply #14 from Elemental Forums Top

I'm editing through each stamp via the .xml, no special editor notepad++

I have to use my imagination. Yes, there are some stamps with the phantom river problem, but I've fixed other stamps and they still end up with phantom rivers. I cannot fix that problem when it is how the computer puts the stamps together and disconnects a river with that stamp. My suggestion for them in that case is to utilize the sub-terrain as the main terrain if a river has been cut off by another stamp.

Currently, I've finished basically all the wildland stamps and generic small stamps.

Reply #15 from Elemental Forums Top

Quoting parrottmath, reply 14
I'm editing through each stamp via the .xml

Damn!  I was trying to load them into the Cartographer.  Silly me.

Thanks for all your hard work.

Reply #16 from Elemental Forums Top

I've done some more fixes to the generic stamps. Small and Medium (mostly just minor fixes, but there are some work redone on some of the stamps

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Generic_Small_stampfixes.zip

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Generic_Medium_stampfixes.zip

Changes:

S_Generic_Small_08.xml

Changed Tile (10,6) to Cliff...matching <MapRiverData>

S_Generic_Small_07.xml

Changed Tile (10,5) to Cliff...matching <MapRiverData>

S_Generic_Small_02.xml

Changed Tile (14,10) to Cliff... matching <MapRiverData>
Changed Tile (14,9) to Cliff
Changed Tile (14,11) to Cliff
Changed Tile (15,11) to Cliff
Changed Tile (15,9) to Cliff
Changed Tile (16,9) to Cliff
Added Tile (16,10) to Submerged
Changed Tile (16,11) to Cliff
Changed Tile (17,11) to Cliff
Added Tile (15,10) to be submerged

S_Generic_Medium_12.xml

Changed Tile (10,10) to river... matching <MapRiverData>
Changed Tile (10,11) to river... matching <MapRiverData>
Changed Tile (7,13) to river... matching <MapRiverData>

S_Generic_Medium_10.xml

Changed Tile (11,11) to river... matching <MapRiverData>
Changed Tile (12,11) to river... matching <MapRiverData>
Changed Tile (13,11) to river... matching <MapRiverData>

S_Generic_Medium_05.xml

Changed Tile (14,10) to cliff... matching <MapRiverData>
Changed Tile (18,10) to cliff... matching <MapRiverData>
Changed Tile (8,9) to Fertile_Land matching <MapRiverData>
Changed Tile (9,8) to Fertile_Land matching <MapRiverData>

S_Generic_Medium_04.xml

Changed Tile (7,13) to Rugged_Land... matching <MapRiverData>
Changed Tile (14,10) to Cliff... matching <MapRiverData>
Changed Tile (18,10) to Cliff... matching <MapRiverData>

S_Generic_Medium_03.xml

Removed the following from <MapRiverData>
Tiles (-22,-22),(-23,-22),(-23,-21),(-23,-20),(-24,-20),(-25,-20),
(-25,-19),(-26,-19),(-27,-19),(-28,-19),(-29,-19),(-29,-20),
(-30,-20),(-30,-21),(-30,-22),(-21,-22)

S_Generic_Medium_02.xml

Changed Tile (18,9) to Cliff... matching <MapRiverData>

Reply #17 from Elemental Forums Top

All checked in, thanks Parrottmath!

Reply #18 from Elemental Forums Top

Here are some more fixes... (Note that I am only matching up the river data and doing changes, specifically around the river and not other fixes to these stamps)

All S_Generic_... have been river fixed.

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Generic_Huge_Stampfixes.zip

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Generic_Large_StampFixes.zip

Changes:

S_Generic_Large_02.xml

Changed Tile (9,14) to Cliff... matching <MapRiverData>
Changed Tile (17,8) to Cliff... matching <MapRiverData>
Changed Tile (28,11) to Land... matching <MapRiverData>
Changed Tile (29,11) to Rugged_Land... matching <MapRiverData>
Changed tile (8,14) to Cliff...

S_Generic_Huge_10.xml

Changed Tile (9,21) to River... matching <MapRiverData>

S_Generic_Huge_03.xml

Changed Tile (10,13) to Cliff... matching <MapRiverData>

S_Generic_Huge_02.xml

Changed Tile (8,22) to Cliff... matching <MapRiverData>
Changed Tile (25,6) to Cliff... matching <MapRiverData>
Changed Tile (25,30) to Cliff... matching <MapRiverData>
Changed Tile (26,7) to Fertile_Land... matching <MapRiverData>
Changed Tile (41,14) to Cliff... matching <MapRiverData>

S_Generic_Huge_01.xml

Changed Tile (41,6) to Cliff... matching <MapRiverData>

Reply #19 from Elemental Forums Top


Major thanks to Parrotmath, and all the other modders donating their time to helping the devs root through what may as well be ancient Sanskrit to me, you guys rock.

 

Looking forward to seeing these fixes implemented in the next patch.

Reply #20 from Elemental Forums Top

Latest all added, keep them coming!

Reply #21 from Elemental Forums Top

The first set of fertile stamps fixed Medium and Small

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Fertile_SmallMedium_StampFixes.zip

changes:

S_Fertile_Small_10.xml

Changed Tile (14,8) to Cliff... matching <MapRiverData>

S_Fertile_Small_01.xmo

Change Tile (5,9) to cliff
Changed Tile (6,10) to cliff... matching <MapRiverData>
Changed Tile (6,9) to cliff...
changed Tile (6,11) to cliff...
Changed tile (5,11) to cliff...
Added Tile (5,10) to be submerged...
Changed Tile (4,9) to cliff...
Changed Tile (4,11) to cliff...

S_Fertile_Medium_08.xml

Changed Tile (14,12) to Cliff... matching <MapRiverData>

S_Fertile_Medium_07.xml

Changed Tile (15,4) to Cliff... matching <MapRiverData>

S_Fertile_Medium_06.xml

Changed Tile (17,7) to Land... matching <MapRiverData>
Changed Tile (17,8) to Land... matching <MapRiverData>
Changed Tile (18,6) to Fertile_Land... matching <MapRiverData>
Changed Tile (18,10) to Cliff... matching <MapRiverData>
Changed Tile (23,8) to Land... matching <MapRiverData>
Changed Tile (24,9) to Land... matching <MapRiverData>

S_Fertile_Medium_03.xml

Changed tile (5,8) to Cliff... matching <MapRiverData>

S_Fertile_Medium_02.xml

Changed Tile (28,13) to Cliff... matching <MapRiverData>

Reply #22 from Elemental Forums Top

Quoting Gandalftheredskin, reply 19


Major thanks to Parrotmath, and all the other modders donating their time to helping the devs root through what may as well be ancient Sanskrit to me, you guys rock.

 

Looking forward to seeing these fixes implemented in the next patch.

 

Well said. Thanks to all of you guys.

Reply #23 from Elemental Forums Top

The Large and Huge Fertile map fixes...

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Fertile_LargeHuge_StampFixes.zip

S_Fertile_Large_05.xml

Changed Tile (29,20) to Cliff... matching <MapRiverData>
Changed Tile (29,19) to Cliff...
Changed Tile (29,21) to Cliff...
Changed Tile (30,19) to Cliff...
Changed Tile (30,21) to Cliff...
Added Tile (30,20) to be submerged
Changed Tile (31,19) to Cliff...
Changed Tile (31,21) to Cliff...

S_Fertile_Large_04.xml

Changed Tile (8,28) to Cliff... matching <MapRiverData>
Added Tile (8,29) to be submerged
Changed Tile (7,28) to Cliff...
Changed Tile (7,29) to Cliff...
Changed Tile (7,30) to Cliff...
Changed Tile (9,28) to Cliff...
Changed Tile (9,29) to Cliff...
Changed Tile (9,30) to Cliff...

S_Fertile_Large_03.xml

Changed Tile (30,20) to Cliff... matching <MapRiverData>

S_Fertile_Large_02.xml

Changed Tile (10,19) to Cliff... matching <MapRiverData>

S_Fertile_Large_01.xml

Changed Tile (19,5) to Cliff... matching <MapRiverData>
Added Tile (19,4) to be Submerged
Added Tile (19,3) to be submerged
Changed Tile (20,3) to Cliff...
Changed Tile (20,4) to Cliff...
Changed Tile (20,5) to Cliff...
Changed Tile (18,3) to Cliff...
Changed Tile (18,4) to Cliff...
Changed Tile (18,5) to Cliff...

S_Fertile_Huge_04.xml

Changed Tile (32,17) to Cliff... matching <MapRiverData>

S_Fertile_Huge_03.xml

Changed Tile (33,17) to Cliff... matching <MapRiverData>

S_Fertile_Huge_02.xml

Changed Tile (10,25) to Cliff... matching <MapRiverData>
Changed Tile (21,12) to Cliff... matching <MapRiverData>

S_Fertile_Huge_01.xml

Changed Tile (27,17) to Cliff... matching <MapRiverData>
Changed Tile (28,26) to Cliff... matching <MapRiverData>
Changed Tile (30,9) to Cliff... matching <MapRiverData>

Reply #24 from Elemental Forums Top

Here are the last bits of stamp fixes. Noticed a lot of Phantom river tiles in these ones. finally fixed ;) I'd do a similar check with the map-pack stamps, but I never purchased it.

 https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/StampFixes/S_Chasms_HugeLargeMedium_FixesCT.zip

Changes:

S_Curgens_Tomb_Blank_01.xml

Changed Tile (15,2) to Cliff...

S_Chasms_Medium_07.xml

Changed Tile (5,9) to Cliff... matching <MapRiverData>

S_Chasms_Medium_05.xml

Removed from <MapRiverData>
Tile (-29,-22),(-30,-22),(-30,-23),(-30,-24),(-31,-24),(-32,-24),(-33,-23),(-34,-23),
(-35,-23),(-36,-23),(-37,-23),(-38,-24),(-39,-24),(-40,-24),(-41,-24),(-41,-24),
(-41,-23),(-42,-23),(-43,-23),(-32,-23)

S_Chasms_Large_04.xml

Changed Tile (18,23) to Cliff... matching <MapRiverData>

S_Chasms_Large_02.xml

Changed Tile (5,8) to Cliff... matching <MapRiverData>
Changed Tile (25,6) to Cliff... matching <MapRiverData>

S_Chasms_Large_01.xml

Changed Tile (16,9) to Cliff... matching <MapRiverData>

S_Chasms_Huge_03.xml

Changed Tile (10,18) to Rugged_Land... matching <MapRiverData>
Changed Tile (11,16) to Land... matching <MapRiverData>
Changed Tile (11,18) to Fertile_Land... matching <MapRiverData>
Changed Tile (13,15) to Land... matching <MapRiverData>
Changed Tile (14,26) to Forest... matching <MapRiverData>
Changed Tile (15,26) to Forest... matching <MapRiverData>
Changed Tile (16,26) to Rugged_Land... matching <MapRiverData>
Changed Tile (18,9) to Cliff... matching <MapRiverData>
Changed Tile (19,15) to Rugged_Land... matching <MapRiverData>
Changed Tile (20,17) to Fertile_Land... matching <MapRiverData>
Changed Tile (21,28) to Fertile_Land... matching <MapRiverData>
Changed Tile (31,18) to Cliff... matching <MapRiverData>

S_Chasms_Huge_02.xml

Changed Tile (26,10) to Cliff... matching <MapRiverData>
Changed Tile (32,10) to Cliff... Matching <MapRiverData>
Changed Tile (34,8) to Rugged_Land... Matching <MapRiverData>
Changed Tile (36,8) to Land... Matching <MapRiverData>
Changed Tile (38,10) to HillsTerrain... Matching <MapRiverData>
Changed Tile (39,11) to HillsTerrain... Matching <MapRiverData>
Changed Tile (40,11) to HillsTerrain... Matching <MapRiverData>
Changed Tile (41,12) to Land... Matching <MapRiverData>

S_Chasms_Huge_01.xml

Changed Tile (4,25) to Cliff... matching <MapRiverData>
Changed Tile (8,22) to Rugged_Land... matching <MapRiverData>
Changed Tile (10,23) to Rugged_Land... matching <MapRiverData>
Changed Tile (12,25) to Rugged_Land... matching <MapRiverData>
Changed Tile (13,26) to Land... matching <MapRiverData>
Changed Tile (14,26) to Land... matching <MapRiverData>
Changed Tile (14,27) to Fertile_Land... matching <MapRiverData>
Changed Tile (15,27) to Fertile_Land... matching <MapRiverData>
Changed Tile (44,7) to Cliff... matching <MapRiverData>
Changed Tile (45,20) to Rugged_Land... matching <MapRiverData>
Changed Tile (46,20) to Rugged_Land... matching <MapRiverData>

Reply #25 from Elemental Forums Top

Quoting parrottmath, reply 24
I'd do a similar check with the map-pack stamps, but I never purchased it.

With all the work you've done I'd think Brad might give it to you for free :grin: