[eWIP] Diplomacy Changes

from Elemental Forums

Ok: my first, super-simple mod is a change in the way research treaties and trade treaties work.

Instead of each trade or research treaty giving each person involved a 1.1 multiplier, these treaties will now give a bonus equal to .1 of the other parties income or research.

I was very lucky in making this, because the very first change I made achieved my goal. The new problem, however, is that I cannot get the modified treaties to change the old treaties. I would be very grateful if someone helped me with this.

Here is the current code. Right now, since the old treaties currently replace my new ones, to actually try them you will need to give each treaty a new internal name or display name, or both (I haven't tested that out). For testing, it also speeds things up to remove the prerequisites.

Code: xml
  1. <?xml version="1.0" encoding="iso-8859-1" standalone="yes"?>
  2. <Treaties>
  3.     <DataChecksum NoParse="1">
  4.         <Ignore>DisplayName,Description</Ignore>
  5.         <Translate>DisplayName,Description</Translate>
  6.     </DataChecksum>
  8. <Treaty InternalName = "TradeTreaty" Type = "Trade">
  9.         <DisplayName>Trade Treaty</DisplayName>
  10.     <Image>Action_Treaty.png</Image>
  11.         <Description>Both parties get a bonus to their per-turn income equal to 10% of the other party's income.</Description>
  12.         <TreatyValueDescription><![CDATA[[Player_1] will receive an additional [TreatyValue1WithUnits] and [Player_2] will receive an additional [TreatyValue2WithUnits]]]></TreatyValueDescription>
  13.         <Units>gp/turn</Units>
  14.         <Duration>-1</Duration>
  15.         <BasePerceivedValue>10000</BasePerceivedValue>
  16.         <MinimumRelations><![CDATA[[RELATIONS_NEUTRAL]]]></MinimumRelations>
  17.         <Calculate InternalName = "IncomeBonus" ValueOwner="Player_2">
  18.             <Expression><![CDATA[0.1*[Income]]]></Expression>
  19.         </Calculate>
  20.         <!-- Any one of these prereqs can be fulfilled to unlock this treaty -->
  21.         <Prereq>
  22.             <Type>Tech</Type>
  23.             <Attribute>Treaties_Amarian</Attribute>
  24.             <Value>0</Value>
  25.         </Prereq>
  26.         <Prereq>
  27.             <Type>Tech</Type>
  28.             <Attribute>Treaties_Trogs</Attribute>
  29.             <Value>0</Value>
  30.         </Prereq>
  31.     </Treaty>
  33.         <Treaty InternalName = "TechTreaty" Type = "Trade">
  34.         <DisplayName>Technology Treaty</DisplayName>
  35.         <Description>Both parties get a bonus to their tech research equal to 10% of the other party's tech research.</Description>
  36.         <TreatyValueDescription><![CDATA[[Player_1] will receive an additional [TreatyValue1WithUnits] and [Player_2] will receive an additional [TreatyValue2WithUnits]]]></TreatyValueDescription>
  37.         <Duration>-1</Duration>
  38.     <Image>Action_Treaty.png</Image>
  39.     <Units>Tech Knowledge per turn</Units>
  40.     <OneUnit>Tech Knowledge per turn</OneUnit>
  41.     <BasePerceivedValue>10000</BasePerceivedValue>
  42.     <MinimumRelations><![CDATA[[RELATIONS_NEUTRAL]]]></MinimumRelations>
  43.     <Calculate InternalName = "ResearchPointsBonus" ValueOwner="Player_2">
  44.       <Expression><![CDATA[[ResearchPoints]*0.1]]></Expression>
  45.     </Calculate>
  46.     <!-- Any one of these prereqs can be fulfilled to unlock this treaty -->
  47.     <Prereq>
  48.       <Type>Tech</Type>
  49.       <Attribute>Treaties_Amarian</Attribute>
  50.       <Value>0</Value>
  51.     </Prereq>
  52.     <Prereq>
  53.       <Type>Tech</Type>
  54.       <Attribute>Treaties_Trogs</Attribute>
  55.       <Value>0</Value>
  56.     </Prereq>
  57.   </Treaty>
  59. </Treaties>

To get the treaties to work differently, all I had to do was change "ValueOwner" from "Player_1" to "Player_2"!

 

Also, if anyone knows where the other diplomatic option files are located (if xml files exist), like for trading or marriage, I would be grateful for the information.

7,141 views 3 replies
Reply #1 from Elemental Forums Top

Onionfighter, here is a fairly simple solution to your treaty issue.

Code: xml
  3. <?xml version="1.0" encoding="iso-8859-1" standalone="yes"?>
  4. <Treaties>
  5.     <Treaty InternalName = "TradeTreaty" Type = "Trade">
  6.         <Calculate InternalName = "IncomeBonus" ValueOwner="Player_2">
  7.             <Expression><![CDATA[0.1*[Income]]]></Expression>
  8.         </Calculate>
  9.     </Treaty>
  10. </Treaties>

This code does everything that your code does, and overrides the current treaty. Ok so I know this doesn't look anything like what you are doing here but I will try to explain it a bit. One of the big things about the way elemental handles mods is the way it handles named references. If you want to modify only one part of a reference, you only need to "call" the reference then specify the exact change you want to make. So above, all we are doing is referencing the treaty, and telling the system that this is the calculation we want for this treaty. Now the sake of example, say you wanted to give these modded treaties a duration. All you would do is a single line for the modified duration and the system will use the modified version instead of the regular version. This tends to work for most of the xml files, though game modifiers do not follow this logic as they are loaded immediately and usually require a counter modifier to get rid of the bonus.

Edit: sorry about the odd link there, the forums make 1 *  into 1*

+1 Loading…
Reply #2 from Elemental Forums Top

Thanks for the help. It is good to know that I don't have to rebuild everything in the file. What I still cannot understand is why your change would be successful in replacing the option while mine is not.

Galactic Civilizations IV
Reply #3 from Elemental Forums Top

Honestly I have no clue why it works when you replace a little but not when you replace a lot. I would bet there is some kind of check in place that looks at the entry and uses some heuristic to determine if it is the same or different. This check probably doesn't kick in when you don't specify certain fields, like the display name or description. Though honestly, the method I have shown above is a good modding practice so that you are not attempting to override every value of an entry with a duplicate value and future modders can clearly see what changes you are adding.